Local helpers not resolved in tests

[NullVoxPopuli]

Build Error (PackagerRunner) in tests/rendering/compile-hbs-test.ts

Module build failed (from ../../../../../home/me/Development/NullVoxPopuli/ember-play/node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
$TMPDIR/embroider/5e47be/tests/dummy/tests/rendering/compile-hbs-test.ts/compile-hbs-test.ts: Missing helper: this.compile in tests/rendering/compile-hbs-test.ts

    at CompatResolver.dependenciesOf (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@embroider/compat/src/resolver.js:251:33)
    at NodeTemplateCompiler.precompile (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@embroider/core/src/template-compiler-common.js:78:42)
    at handleTagged (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@embroider/core/src/babel-plugin-inline-hbs.js:68:62)
    at PluginPass.TaggedTemplateExpression (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@embroider/core/src/babel-plugin-inline-hbs.js:38:29)
    at PluginPass.<anonymous> (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@embroider/core/src/portable-babel-launcher.js:37:29)
    at newFn (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@babel/traverse/lib/visitors.js:171:21)
    at NodePath._call (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@babel/traverse/lib/path/context.js:90:31)
    at TraversalContext.visitQueue (/home/me/Development/NullVoxPopuli/ember-play/node_modules/@babel/traverse/lib/context.js:99:16)

  test('it works', async function (assert) {
    assert.expect(5);

    this.setProperties({
      compile: () => {
        let template = `
          {{#each (array 1 2) as |num|}}
            <output>{{num}}</output>
          {{/each}}
        `;

        let {component, name, error} = compileHBS(template);

        assert.notOk(error);
        assert.ok(name);

        return component;
      },
    });

    await render(
      hbs`
        {{#let (this.compile) as |CustomComponent|}}
          <CustomComponent />
        {{/let}}
      `
    );

    assert.dom('output').exists({count: 2});
    assert.dom().containsText('1');
    assert.dom().containsText('2');
  });

this occurs during the embroider-optimized build of my addon with the additional following config in the ember-cli-build:

  const { maybeEmbroider } = require('@embroider/test-setup');

  return maybeEmbroider(app, {
    packageRules: [
      {
        package: 'dummy',
        helpers: {
          '{{this.compile}}': { safeToIgnore: true },
        },
      },
    ],
    packagerOptions: {
      webpackConfig: {
        node: {
          global: false,
          __filename: true,
          __dirname: true,
        },
        resolve: {
          fallback: {
            path: 'path-browserify',
          },
        },
      },
    },
  });

[NullVoxPopuli]

I can kinda get past this with a non-ideal way via staticHelpers: false, but I don't think that's a great solution, as I do technically have a statically-analyzeable helper.

[lifeart]

looks like this in tests is a pain, in my understanding it should be runtime error (or wrapped with runtime assert), instead of build one

[ef4]

The extra parentheses here mean you're trying to invoke this.compile as a helper:

{{#let (this.compile) as |CustomComponent|}}

I think it will work fine if you do this:

{{#let this.compile as |CustomComponent|}}

[NullVoxPopuli]

I have a plain-function helper-manager, so (this.compile) is correct

[lifeart]

error bubbling from

embroider/packages/compat/src/resolver.ts

Line 573 in bf888b1

if (!this.staticHelpersEnabled) {

looks like resolver don't check JS/TS tokens around HBS templates (in general)

embroider/packages/compat/src/resolver-transform.ts

Line 70 in 75344d8

resolver.resolveSubExpression(node.path.original, filename, node.path.loc);

[lifeart]

should be used something like "getTemplateTokens" from

https://github.com/glimmerjs/glimmer-experimental/blob/116fa295b2396ff5ae409e6cf537df30455e8ad2/packages/%40glimmerx/babel-plugin-component-templates/index.js

but, it's moved in glimmerjs/glimmer-experimental#102 and I'm not shure about new location for this logic

update:

found it - https://github.com/glimmerjs/glimmer-experimental/blob/012baffa288070784641d565a22a4cbc7f77702a/packages/%40glimmerx/eslint-plugin/lib/rules/template-vars.js#L1

now it's const { getTemplateLocals } = require('@glimmer/syntax');