Could not find module ember-get-config imported from (require)

[maxymczech]

Hello. I am trying to migrate Ember app to Embroider and I am getting this error from several addon packages:

• ember-cli-moment-shim
• ember-drag-drop-polyfill

I am using Ember 3.26 and Embroider 0.41.0

[maxymczech]

@alexlafroscia it seems this error might be caused by ember-get-config compat adapter that you wrote in #770. I have tried removing it from my node_modules/@embroider/compat/src/ember-get-config.* and now my application loads perfectly fine. What could be the reason for that? If you have time, can you please look into this?

[ef4]

It’s possible to disable a built in compat adapter if it’s causing trouble. You set the `compatAdapters` option to a Map where the name of the addon maps to null.

…

On Mon, May 24, 2021 at 8:38 AM Maksym Shcherban ***@***.***> wrote: @alexlafroscia <https://github.com/alexlafroscia> it seems this error might be caused by ember-get-config compat adapter that you wrote in #770 <#770>. I have tried removing it from my ***@***.***/compat/src/ember-get-config.* and now my application loads perfectly fine. What could be the reason for that? If you have time, can you please look into this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#823 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACN6MTYON2U3P4UZFZXZJDTPJCCRANCNFSM45ND5Q3Q> .

[maxymczech]

@ef4 Thank you very much, it works. The question however remains, why did the compat adapter cause problems in the first place.

[ef4]

Agreed, that is just a workaround until we can sort it out. If it's not needed, great, we can delete it. The goal is to eventually delete all the compat adapters as addons become compatible enough without them.

[maxymczech]

Thank you for clarification. In that case I am closing the issue.

[ef4]

We can keep this open so we remember to either delete it or figure out which versions really need it.

[alexlafroscia]

The compat adapter was created originally because ember-get-config generates (or did, at the time that I wrote it) a module that itself depends on your host app without actually listing it as a dependency. This kind of implicit dependency on a module -- especially when that module is the host app -- isn't valid.

When talking through that fact with @ef4, it was suggested that we use a compat adapter to generate a different implementation with the same outcome, that doesn't require the addon depending on the host app.

It's possible ember-get-config has updated to no longer do that, or do it in a safer way.

What kind of error did you see?

[maxymczech]

What kind of error did you see?

The one in issue title: Could not find module ember-get-config imported from (require)

[johanrd]

I get the same error as @maxymczech above when running with v >= 0.41 (when e.g. ember-cli-notifications is installed). No errors when building with v0.40.

Adding compatAdapters: new Map([['ember-get-config', null]]) did not seem to help, so I'm stranded on v0.40 for now.

[maxymczech]

@johanrd Our app is currently on version 0.43.0 of embroider. Here is the config that is currently working for me, maybe something from there will help:

  return require('@embroider/compat').compatBuild(app, Webpack, {
    compatAdapters: new Map([
      ['ember-get-config', null]
    ]),

    packagerOptions: {
      webpackConfig: {
        // Generate source maps
        devtool: (process.env.EMBER_ENV === 'production' ? 'cheap-source-map' : 'eval'),

        plugins: [
          new MomentLocalesPlugin({
            localesToKeep: ['cs']
          })
        ],

        module: {
          rules: [{
            test: /ember-concurrency/,
            loader: 'string-replace-loader',
            options: {
              multiple: [
                {
                  search: '\\[yieldableSymbol\\]',
                  flags: 'g',
                  replace: '["__ec_yieldable__"]'
                },
                {
                  search: '\\[cancelableSymbol\\]',
                  flags: 'g',
                  replace: '["__ec_cancel__"]'
                }
              ]
            }
          }]
        }
      }
    },
    splitAtRoutes: [/^((?!application).)*$/],
    staticAddonTestSupportTrees: true,
    staticAddonTrees: true,
    staticComponents: true,
    staticHelpers: true
  });

[johanrd]

@maxymczech thanks, tried again now, and it worked! Not sure why it failed an hour ago, thanks for the message.

[johanrd]

FYI: Tried to reproduce now, and the issue comes back if I regenerate the yarn.lock file from scratch. Thus, the fix seems a bit vulnerable. Not sure what pin change is causing it, though.

[rahulk94]

FYI: Tried to reproduce now, and the issue comes back if I regenerate the yarn.lock file from scratch. Thus, the fix seems a bit vulnerable. Not sure what pin change is causing it, though.

I also had things working previously with the existing ember-get-config compat adapter but after rebasing my branch onto master and regenerating my lock file with changes for Embroider this issue has come back for me. Setting the compat adapter to null also doesn't help unfortunately.

[ef4]

This issue is fixed in PR #1030, which isn't merged yet.