Webpack is using the Ember global in compiled templates

[sandydoo]

Summary

I think Webpack is turning imports of createTemplateFactory into a reference to Ember.HTMLBars.template, which throws deprecation notices in apps running 3.27+.

In more detail

As of v3.27, accessing the Ember global throws a deprecation notice.

ember-cli-htmlbars was recently updated to replace Ember.HTMLBars.template with module imports.

Now, templates should be compiled with:

import { createTemplateFactory } from '@ember/template-factory';
export default createTemplateFactory(${precompiled});

But in apps built with Embroider specifically, what we see is the following:

const createTemplateFactory = Ember.HTMLBars.template;
...

My hunch is that Webpack is doing this, but I have no proof 🤣.
Any ideas? Am I completely wrong here?

Steps to reproduce

Run ember new with [email protected].
Inspect the console logs. You should see a warning coming from application.hbs.

Versions used for testing

@embroider/*: 0.39.1 && 0.40.0
ember-source: 3.27.0-beta.4
ember-cli-htmlbars: 5.7.1

[ef4]

This is supposed to be handled here, could you poke around and see what's happening in that spot?

[sandydoo]

Never mind! I was totally wrong. It was this:

embroider/packages/core/src/mini-modules-polyfill.ts

Lines 28 to 35 in d36a045

	'@ember/template-factory': {
	createTemplateFactory(t) {
	return t.memberExpression(
	t.memberExpression(t.identifier('Ember'), t.identifier('HTMLBars')),
	t.identifier('template')
	);
	},
	},

This polyfill is being run in apps on the 3.27.0-beta.x range because this semver check resolves to true for these versions. It’s a bit annoying, but it will resolve itself when 3.27.0 is released.

embroider/packages/compat/src/compat-app.ts

Line 368 in 8137a35

let emberNeedsModulesPolyfill = semver.satisfies(emberSource.version, '<3.27.0', { includePrerelease: true });

// ¯\(°_o)/¯ I guess
semver.satisfies('3.27.0-beta.4', '<3.27.0', { includePrerelease: true })
// > true
semver.satisfies('3.27.0-beta.4', '<3.27.0-beta.0', { includePrerelease: true })
// > false

[sandydoo]

This is supposed to be handled here, could you poke around and see what's happening in that spot?

Just as I’m about to close the issue 😅 Great timing!

[ef4]

We should probably still change that condition so it allows the beta series. I think semver.satisfies(emberSource.version, '<3.27.0-beta.0', { includePrerelease: true }) would do it and be more correct.