Issue w/ ember-data

[thoov]

Hitting the following error when pairing with @stefanpenner:

Uncaught Error: Could not find module `@ember/application/deprecations` imported from `(require)`
    at missingModule (loader.js:247)
    at findModule (loader.js:258)
    at requireModule (loader.js:24)
    at eval (deprecations.js:2)
    at Object.../externals/@ember/application/deprecations.js (chunk.7a7f2b06daf33070bcbf.js:10)
    at __webpack_require__ (chunk.2b560a58216735ee49fd.js:79)
    at eval (index.js:11)
    at Module../node_modules/ember-inflector/index.js (chunk.d98733368d0da5a70d5c.js:1240)
    at __webpack_require__ (chunk.2b560a58216735ee49fd.js:79)
    at eval (relationship-meta.js:4)

After removing ember-data from package.json the error goes away.

Steps to reproduce:

1. ember new sample-app --yarn
2. Link embroider to sample app
3. Modify ember-cli-build.js with:

  if (process.env.EMBROIDER) {
    const Webpack = require('@embroider/webpack').Webpack;
    return require('@embroider/compat').compatBuild(app, Webpack, {
      compatAdapters: new Map([['ember-decorators', null]])
    });
  } else {
    return app.toTree();
  }

4. Run EMBROIDER=true ember s
5. Visit localhost:4200 and open up the console

[stefanpenner]

looks like @ember/application/deprecations was added somewhat recently: emberjs/ember-cli-babel#286 (@rwjblue pointed this out)

I am confused why #218 doesn't fix this scenario...

[stefanpenner]

doing upgrades, I also hit this problem, so the following PR contains a reproduction: #239

[stefanpenner]

I think i found the issue: https://github.com/embroider-build/embroider/pull/218/files#r295518004 although flipping that, seems to run into other issues.. :P