Ember 4.1+ || Error while processing route: ember window.Ember is undefined -- related: can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization

[NullVoxPopuli]

This is a preliminary issue, but cropped up -- not sure why yet.

There is only one occurrence of window.Ember:

which comes from:

which is defined here:

embroider/packages/util/addon/ember-private-api.js

Lines 9 to 19 in fb86676

	if (
	macroCondition(
	dependencySatisfies('ember-source', '>=3.27.0-canary || >=3.27.0-beta')
	)
	) {
	// new enough ember has a real module we can import
	runtime = importSync('@glimmer/runtime');
	} else {
	// older ember has its own internal loader
	runtime = window.Ember.__loader.require('@glimmer/runtime');
	}

Here is the code / error:

Error while processing route: index window.Ember is undefined ../node_modules/@embroider/util/ember-private-api.js@http://localhost:4200/assets/chunk.4c6a1d188e8b66e667de.js:32527:3
__webpack_require__@http://localhost:4200/assets/chunk.366fbe0dd169a8169677.js:23:42
../node_modules/@embroider/util/index.js@http://localhost:4200/assets/chunk.4c6a1d188e8b66e667de.js:32618:95
__webpack_require__@http://localhost:4200/assets/chunk.366fbe0dd169a8169677.js:23:42

and related error:

can't access lexical declaration '__WEBPACK_DEFAULT_EXPORT__' before initialization

[NullVoxPopuli]

if I revert back to Ember 4.0.1 the error goes away, so this seems to be an issue with dependencySatisfies?

[NullVoxPopuli]

I confirm the fix by changing the macroCondition to just true in node_modules. but I am unable to get 4.1.0-beta or 4.2.0-alpha to match the dependencySatisfies

[NullVoxPopuli]

I tried adding >= 4.0.0 to the dependencySatisfies condition, but:

still false.

[Windvis]

I don't think it's an issue with the SemVer version range itself. includePrerelease is set so it should also match the prerelease versions.

Can you debug the dependencySatisfies macro to see from where it returns false?

[NullVoxPopuli]

adding console.logs in node_modules seems to not show anything 🤷

[NullVoxPopuli]

ah ha!

embroider/packages/macros/src/babel/dependency-satisfies.ts

Line 39 in 1f40072

if (err.code !== 'MODULE_NOT_FOUND') {

I'm falling in to this branch --

unable to resolve package ember-source from /tmp/embroider/66dd2e/node_modules/@embroider/util
unable to resolve package ember-source from /tmp/embroider/66dd2e/node_modules/ember-focus-trap

(but multiple times)

at PackageCache.resolve (/✂️/limber/node_modules/@embroider/shared-internals/src/package-cache.js:29:21)
    at dependencySatisfies (/✂️/limber/node_modules/@embroider/macros/src/babel/dependency-satisfies.js:40:36)
    at Evaluator.evaluateMacroCall (/✂️/limber/node_modules/@embroider/macros/src/babel/evaluate-json.js:319:81)
    at PluginPass.enter (/✂️/limber/node_modules/@embroider/macros/src/babel/macros-babel-plugin.js:127:71)
    at newFn (/✂️/limber/node_modules/@babel/traverse/lib/visitors.js:177:21)
    at NodePath._call (/✂️/limber/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/✂️/limber/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/✂️/limber/node_modules/@babel/traverse/lib/path/context.js:100:31)
    at TraversalContext.visitQueue (/✂️/limber/node_modules/@babel/traverse/lib/context.js:103:16)

[NullVoxPopuli]

@ef4 would it make sense to fall back to the app's ember-source if we get in to this branch?

[ef4]

In older APIs that we're trying not to break we allow that kind of fallback. But this is new API and we're trying to be strict.

Instead we should list ember-source as a peerDep of @embroider/util, so that it's always resolvable regardless of hoisting / monorepos / alternative package managers.

[NullVoxPopuli]

Here is my work-around for now:

// @ts-check
'use strict';

const path = require('path');
const fs = require('fs/promises');

const modules = path.join(__dirname, 'node_modules');

/**
  * These are patches to packages where things work for
  * this project, but I don't yet know what the proper way to fix the issue
  * for real is.
  */
async function start() {
  await patchEmbroiderIssue1038();
}

async function patchEmbroiderIssue1038() {
  console.log('Patching @embroider/util due to https://github.com/embroider-build/embroider/issues/1038');

  let emberPrivateApi = path.join(modules, '@embroider/util/addon/ember-private-api.js');
  let fileBuffer = await fs.readFile(emberPrivateApi);
  let file = fileBuffer.toString();

  // the macro-condition for this file doesn't work because embroider can't find
  // ember-source.
  // since we know that
  file = file.replace(/macroCondition\(/, 'true || (');

  await fs.writeFile(emberPrivateApi, file);
}

start();

and then in package.json:

  "scripts": {
    "prepare": "node patch-packages.js",