Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we _not_ transpile away class properties? #1016

Closed
NullVoxPopuli opened this issue Nov 6, 2021 · 2 comments
Closed

How do we _not_ transpile away class properties? #1016

NullVoxPopuli opened this issue Nov 6, 2021 · 2 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Nov 6, 2021

This is related to: emberjs/ember-cli-babel#417

Related embroider issues:

In a default embroider build, class properties (non-decorated), should not be transpiled if they are targeting "last 1 firefox versions", but instead output properties like this:

 (0,_home_nullvoxpopuli_Development_NullVoxPopuli_limber_node_modules_embroider_core_node_modules_babel_runt
ime_helpers_esm_defineProperty__WEBPACK_IMPORTED_MODULE_0__.default)(
  this, 
  "rootURL", 
  _config_environment__WEBPACK_IMPORTED_MODULE_2__.default.rootURL
);

(this is the dev-time output, so its a bit verbose)

This is what I'd expect the output to be:

this.rootURL = _config_environment__WEBPACK_IMPORTED_MODULE_2__.default.rootURL
@NullVoxPopuli
Copy link
Collaborator Author

ah, this is controlled by ember-cli-babel! so once emberjs/ember-cli-babel#417 is resolved, this, #1016, will be resolved

@NullVoxPopuli
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant