Merge pull request #2094 from embroider-build/command-watcher-logs

make CommandWatcher dump logs at shutdown() when a command has failed
embroider-build · Sep 3, 2024 · e1733ef · e1733ef
2 parents bd04b35 + 9fa39a0
commit e1733ef
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/tests/scenarios/helpers/command-watcher.ts b/tests/scenarios/helpers/command-watcher.ts
@@ -105,6 +105,7 @@ export default class CommandWatcher {
 
   async shutdown(): Promise<void> {
     if (this.exitCode != null) {
+      this.maybeEmitLogs();
       return;
     }
 
@@ -119,6 +120,14 @@ export default class CommandWatcher {
     });
 
     await this.waitForExit();
+    this.maybeEmitLogs();
+  }
+
+  private maybeEmitLogs() {
+    if (this.exitCode !== 0) {
+      console.error(`CommandWatcher saw non-zero exit, dumping logs:`);
+      console.error(this.lines.join('\n'));
+    }
   }
 
   async waitForExit(): Promise<number> {