Skip to content

Commit

Permalink
curating virtual packages
Browse files Browse the repository at this point in the history
  • Loading branch information
ef4 committed Mar 30, 2021
1 parent 0a8fa4a commit 2f95b2c
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions packages/shared-internals/src/ember-standard-modules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,14 @@ export const emberVirtualPackages = new Set<string>(mappings.map((m: any) => m.m
// a v1 addon in between the app and a v2 addon might not declare the peerDep,
// breaking the deeper v2 addon.
export const emberVirtualPeerDeps = new Set<string>(['@glimmer/component']);

// this is a real package, even though it's still listed in rfc176
emberVirtualPackages.delete('@ember/string');
emberVirtualPeerDeps.add('@ember/string');

// these can also appear in ember code and should get compiled away by babel,
// but we may need to tell a build tool that is inspecting pre-transpiled code
// (like snowpack) not to worrya bout these packages.
emberVirtualPackages.add('@glimmer/env');
emberVirtualPackages.add('ember');
emberVirtualPackages.add('@embroider/macros');

0 comments on commit 2f95b2c

Please sign in to comment.