Skip to content

Commit

Permalink
Merge pull request #1433 from NullVoxPopuli/fix-ci--the-errorening
Browse files Browse the repository at this point in the history
Make preflight error when suite-setup-util fails
  • Loading branch information
NullVoxPopuli authored May 18, 2023
2 parents 806723a + 82d20d1 commit 18fd6a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
run: pnpm lint
- id: set-matrix
working-directory: test-packages/support
run: echo "matrix=$(node ./suite-setup-util.js --matrix)" >> $GITHUB_OUTPUT
run: |
matrix_json=$(node ./suite-setup-util --matrix)
echo "matrix=$matrix_json" >> $GITHUB_OUTPUT
test:
needs: ['preflight']
Expand Down
2 changes: 1 addition & 1 deletion tests/scenarios/engines-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ engineScenarios
});

engineScenarios
.skip('release') // fails due to https://github.com/emberjs/ember.js/pull/20461
.skip('release-engines') // fails due to https://github.com/emberjs/ember.js/pull/20461
.map('with-fastboot', app => {
app.linkDependency('ember-cli-fastboot', { baseDir: __dirname });
app.linkDependency('fastboot', { baseDir: __dirname });
Expand Down

0 comments on commit 18fd6a9

Please sign in to comment.