Merge pull request #840 from embroider-build/lint-before-running-many…

…-jobs

Run linting in CI before running the full matrix of jobs

.github/workflows/ci.yml

@@ -14,8 +14,30 @@ on:
     branches: [master]
 
 jobs:
+  linting:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    steps:
+      - uses: actions/checkout@v1
+      - uses: volta-cli/action@v1
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "::set-output name=dir::$(yarn cache dir)"
+      - uses: actions/cache@v2
+        id: yarn-cache
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+      - run: yarn --frozen-lockfile
+      - name: lint
+        run: yarn lint
+
   discover_matrix:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
     outputs:
       matrix: ${{ steps.set-matrix.outputs.matrix }}
     steps:
@@ -36,7 +58,7 @@ jobs:
         run: echo "::set-output name=matrix::$(node ./test-packages/support/suite-setup-util.js --matrix)"
 
   test:
-    needs: discover_matrix
+    needs: ["discover_matrix", "linting"]
     name: ${{ matrix.name }}
     runs-on: '${{ matrix.os }}-latest'
     timeout-minutes: 30

test-packages/support/suite-setup-util.ts

@@ -117,13 +117,6 @@ export async function githubMatrix() {
   });
 
   let include = [
-    // add our eslint
-    {
-      name: 'lint',
-      os: 'ubuntu',
-      command: 'yarn lint',
-      dir: resolve(__dirname, '..', '..'),
-    },
     ...suites.map(s => ({
       name: `${s.name} ubuntu`,
       os: 'ubuntu',