Fix wrong detection of ember-source version for earlyBootSet #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
earlyBootSetand running tests for Ember prerelease scenarios, these would fail withautoImport.earlyBootSet is not supported for ember-source <= 3.27.0.Seems in this case we are trying to coerce the tarball URL from
ember-source-channel-urlinto a semver version. Butsemver.coerceseems way too forgiving, somehow returning3.0.0here. Usingvalidhere instead seems to fix this, in the sense that if the package version is not somethingsemvercan understand, then we won't throw the error and assume it's going to be fine./cc @NullVoxPopuli