Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @embroider/virtual instead of @embroider/core for test-support #97

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Use @embroider/virtual instead of @embroider/core for test-support #97

merged 1 commit into from
Oct 4, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Oct 4, 2024 •
edited
Loading

@mansona mansona added the enhancement New feature or request label Oct 4, 2024
mansona
mansona approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NullVoxPopuli NullVoxPopuli merged commit ec657eb into main Oct 4, 2024
4 checks passed
@NullVoxPopuli NullVoxPopuli deleted the use-virtual-instead-of-core branch October 4, 2024 15:12
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
@mansona mansona changed the title Use @embroider/virtual instead of @embroider/core Use @embroider/virtual instead of @embroider/core for test-support Oct 7, 2024
@mansona mansona added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @mansona