Fix support for --typescript

[NullVoxPopuli]

For testing this out (without cloning), I published this branch under @nullvoxpopuli/ember-vite-app

So, creating a TS app would happen like:

npx ember-cli@latest new my-app-name \
  --blueprint @nullvoxpopuli/ember-vite-app \
  --pnpm \
  --typescript

---

Extractions

• Prepare for typescript support by moving all the js files into a js folder #81
• Split the lint and test jobs so we can see tests running during draft work #82
• Add prettier config (with <template> support #83
• Run linting on the generated project in CI // add a working eslintconfig #84
• Use local ember-cli instead of global #88
• Extract project creation util so that multiple test files can share the "ember new + fixture" stuff #87
• Extract an output:fixture command for manual testing #93
• Parameterize the default tests for quickly adding scenarios to test #94
• Move more files to the files-override/shared folder #99
• Use colors for the concurrently prefixes in package.json ember-cli/ember-cli#10515
• Use ESLint 9 and Flat Config ember-cli/ember-cli#10516

---

The upstream blueprint supports --typescript, and a fair number of folks wanting "to try out the Vite blueprint" want to use TypeScript.

The effort required here isn't huge, mostly config changes.

• get TS working
  • support hbs and the template-registry (should this be opt in/out?) will happen in another PR
• remove/convert TS files for the JS output

The Approach:

• split all files by js/ts based on presence of the --typescript option
  • this makes it easier to maintain each set of files, and compare them
  • previous blueprints trying to inline all the conditions for typescript vs not typescript have proven tricky to maintain, and harder to read than they otherwise could be! (like in this PR!)
  • this also allows easier separation since proper TS support is very invasive to a project -- a lot needs to change

What isn't implemented:

• types registry (for loose mode)
• service registry
• models registry

These will show up in future PRs (as this one is already quite big) -- and how we want to teach ember-data in the future also doesn't include models, so I'll need to sink with @runspired on what the strategy should be there (or if ember-data/warp-drive has its own generator, etc (since it's meant to be very "use what you need"))

[mansona]

Lots of little comments, not all of them are blocking but some of them are. Let me know if you have any questions about these 👍

[simonihmig]

@NullVoxPopuli This is a bit hard to review now with all the stuff included that has been extracted into their own PRs. Could you please ping us again, when those extractions have been merged and this rebased?

Thanks for working on this, this is much needed! (for some people at least 🙂 )

[NullVoxPopuli]

of course yes! I don't know how to un-ping people once I put a PR back in to draft status 🙈

[NullVoxPopuli]

this utility is neat -- it re-adds some basic support for extends
-- its kind of a less-powerful version of configFor + forFiles

Here is proof this config works:

This PR is entirely different now

[NullVoxPopuli]

without this change, the vite config in this folder is changed to double quotes...

[NullVoxPopuli]

feels like a prettier bug, tbh, given line 10 here

[mansona]

still a few things left to fix 👍

[mansona]

I have only one more thing that I am not sure about with this PR, it's not a blocker but I think we need to be careful here because stylelint has broken on us in the past

[mansona]

I was just going to merge this PR and have done with it but I saw there were conflicts so can we fix these last few issues and resolve the conflict and we can get this merged 👍

[Alonski]

@NullVoxPopuli Can I help getting this merged please?

[mansona]

👍

[bertdeblock]

.cts is in here twice, and it seems some entries are missing the * character?

[NullVoxPopuli]

Ope

[mansona]

I was going to point out that overrides are overriding what is already being set as the default on line 4 so this whole block is pointless (I think) 🙈

this PR had too much back and forth I just let that one slide

[NullVoxPopuli]

Iteration is easier

Ye