Fixes app import paths in index.html #58
Conversation
| @@ -18,8 +18,8 @@ | |||
|
|
|||
| <script src="/@embroider/core/vendor.js"></script> | |||
| <script type="module"> | |||
| import Application from './app'; | |||
| import environment from './config/environment'; | |||
| import Application from './app/app'; | |||
There was a problem hiding this comment.
because index.html is in the app folder already, the meaning of this import means that app.js is actually located at <repo>/app/app/app.js -- which is wrong.
I think the change in this PR is papering over a side-effect of the rewritten app still existing.
When observing the output, your change does make sense:
However, in source, it does not make sense:
so the index.html would need to move to the root of files-override to to have the imports make sense / not be wrong in source.
With the upcoming removal of app rewriting, the proposed change here will make sense if the index.html were moved outside of the app directory.
However (however), the change here also matches what is in the app-template base-app in the embroider repo.
We can move the index.html out of app later.
This PR fixes the import of file in the index.html file.
Fixes