Skip .gitignore in existing monorepo #129
Conversation
| if (this.isExistingMonorepo) { | ||
| // The .gitignore is used for ignoring files that are moved to the addon from the root folder at build time | ||
| // But this setup does not apply for an existing monorepo (all root files are ignored), so we don't need the .gitignore | ||
| files = files.filter((filename) => filename !== '__addonLocation__/gitignore'); |
There was a problem hiding this comment.
in an existing monorepo we do want to keep the addon's gitignore tho.
each package which can generated ignored files benefits from a local gitignore
Maybe I'm missing something?
is this supposed to be the top-level gitignore?
There was a problem hiding this comment.
The situation changed a bit with merging #136. And actually I am not sure the changed to the addon's .gitignore here were what we really want. I probably missed the fact that this was the addon's local .gitignore, and not the root one...
Previously, the local .gitignore only had this:
/README.md
/LICENSE.md
This was necessary to ignore the files that we copy as part of the build here.
However, in an in-monorepo situation, this is different. We don't copy these files anymore as part of the build, but move them into the addon folder when the blueprint runs. This is then their intended location. But then we must not gitignore them anymore. And as stated above, when those two entries are the only ones in the .gitignore, then taht file does not make any sense anymore. That's why it is not created in this PR.
Back to the changes in #136: I think they should be reverted, that's what I'm doing at #141. Let's discuss that topic over there, in case you disagree...
There was a problem hiding this comment.
Given that #141 has been merged, the change here makes sense again I think. The addon's gitignore again contains only the Readme and License files, which in an existing monorepo must not be ignored as explained above, so we can delete the addon's .gitignore. The "Introduce workspace isolation" PR we talked about will need to adjust that eventually...
The .gitignore is used for ignoring files that are moved to the addon from the root folder at build time. But this setup does not apply for an existing monorepo (all root files are ignored), so we don't need the .gitignore (and it does harm, as it matches the README.md file)
simonihmig
force-pushed
the
fix-gitignore-in-monorepo
branch
from
a7c96aa to
2dedaba
Compare
The
.gitignoreis used for ignoring files that are moved to the addon from the root folder at build time. But this setup does not apply for an existing monorepo (all root files are ignored), so we don't need the.gitignore(and it does harm, as it matches the README.md file)