Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

#68 - Module Unification call for help / contributions #3624

Merged
merged 5 commits into from
Oct 11, 2018
Merged

#68 - Module Unification call for help / contributions #3624

merged 5 commits into from
Oct 11, 2018

Conversation

NullVoxPopuli
Copy link
Contributor

No description provided.

@amyrlam amyrlam requested a review from a team October 10, 2018 17:09
@@ -52,8 +52,17 @@ responsive: true

---

## [SECTION TITLE](#section-url)
## [Module Unification is in the final stretch!](https://github.com/emberjs/ember.js/issues/16373)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it did Module Unification Is in the Final Stretch
wouldn't Module Unification is in the Final Stretch be more correct?
(lowercase is)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say just go with what it says to be consistent, up to you though, nbd!

Have you heard of **Ember's future default project layout**? If you haven't, you can read about it the [Module Unification RFC](https://github.com/emberjs/rfcs/blob/master/text/0143-module-unification.md).

The initial work on Module Unification is **nearly complete**, as **[there are only a handful of tasks left](https://github.com/emberjs/ember.js/issues/16373)** and some of the tasks just need a good amount of spelunking time.
If you can donate some of your time to help finish this up, the entire community will forever be in your debt 💖
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to debt. 💖


Also, if you are a user of namespaced components, [this RFC](https://github.com/emberjs/rfcs/pull/367) is a must read. Please leave your thoughts on the [Module Unification Packages RFC](https://github.com/emberjs/rfcs/pull/367) as nested components affect the majority of Ember projects.

To learn more about Module Unification, feel free to join the #st-module-unification channel on the [Ember Discord](https://discordapp.com/invite/zT3asNS)!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recently learned that you can link to a Discord channel on the web. so could change to [#st-module-unification](https://discordapp.com/channels/480462759797063690/484527343331704832)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly native app

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the invite link be kept? or no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i say keep both to encourage the discord to be moar active, cool?


Curious what a real project looks like with module unifcation? Checkout [emberclear](https://emberclear.io) by [@NullVoxPopuli](http://github.com/nullvoxPopuli/) on [gitlab](https://gitlab.com/NullVoxPopuli/emberclear/tree/master/packages/frontend) or [github](https://github.com/NullVoxPopuli/emberclear/tree/master/packages/frontend)!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry one last comment, this is rad, i love example repos, really helps me learn

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 yay <3

Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @NullVoxPopuli! Feel free to add your name to the author's list at the top and bottom as part of this branch if you want

@@ -52,8 +52,17 @@ responsive: true

---

## [SECTION TITLE](#section-url)
## [Module Unification is in the Final Stretch!](https://github.com/emberjs/ember.js/issues/16373)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry can we put an emoji here? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Which one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author's pick haha Maybe 🛣 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good call, thx @chrisrng! 📈

@NullVoxPopuli
Copy link
Contributor Author

@amyrlam like that? (never added my name before)

@amyrlam
Copy link
Member

amyrlam commented Oct 10, 2018

@NullVoxPopuli we tend to just put our real names a la https://emberjs.com/blog/2018/10/05/the-ember-times-issue-67.html, inconsistent with the rest but more blog-friendly(?)

@NullVoxPopuli
Copy link
Contributor Author

ah ok, can do!

@amyrlam amyrlam merged commit 5ad8a28 into emberjs:blog/embertimes-68 Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants