Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

[#3346] Remove front page slider jump behavior #3347

Closed
wants to merge 1 commit into from

Conversation

Martodox
Copy link

@Martodox Martodox commented May 17, 2018

@jenweber
Copy link
Contributor

@Martodox thanks for your work! Do you have any ideas how to make this work better for smaller than full width screens? Some of the logos end up cut off. I played around with it too and didn't get anywhere.

@Martodox
Copy link
Author

@jenweber it is a definite improvement over previous version. I think in order to make it look good that jquery plugin that is being used as a slider component needs to be removed/replaced with something modern, responsive? What do you think?

@MelSumner
Copy link
Contributor

Hey all- this is sort of a two fold thing-

  1. there's a newer version of the slider we use, could update (has side effects)
  2. as we're working on Emberizing the website (see ember-styleguide) there's sort of the question as to whether or not updating this will be worth it, or if we should push forward with the replacement.

@jenweber thoughts?

@jenweber
Copy link
Contributor

If there are no objections, I think this PR is a net improvement and we should merge it, then worry about other upgrades in later PRs

@locks locks temporarily deployed to ember-website-staging-pr-3347 May 20, 2018 04:03 Inactive
@MelSumner
Copy link
Contributor

Could we make sure the other viewports work too? Here's what I see for a small viewport:
image

@jenweber
Copy link
Contributor

@MelSumner I took a stab at trying to make it work responsively and failed to make any progress. The option flags aren't working the way they're supposed to.

@locks locks temporarily deployed to ember-website-staging-pr-3347 June 1, 2018 12:01 Inactive
@jenweber
Copy link
Contributor

closed with merging #3648

Thanks for trying to help us fix this thing! Multiple people made attempts and the carousel itself was so buggy that a recent contributor just made it a static box.

@jenweber jenweber closed this Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants