-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record Data State #463
Record Data State #463
Conversation
Are there any plans for an Another related property may be |
@mikkopaderes the short answer is that there is not. We did explore whether A TL;DR of what to do instead is check if the RecordData cache has an entry for a given identifier If we start with a bit of context on what In pre-record-data
An unfortunate design within With the In the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor inline comment, but I’d also like to confirm that this RFC has to land after the identifier RFC #403, right?
text/0000-record-data-state.md
Outdated
|
||
isDeleted(identifier: RecordIdentifier): boolean | ||
|
||
isDeletionPersisted(identifier: RecordIdentifier): boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bizarre spacing here, maybe tabs vs spaces or something?
text/0000-record-data-state.md
Outdated
getAttr(identifier: RecordIdentifier, key: string): any; | ||
getRelationship(identifier: RecordIdentifier): JsonApiRelationship; | ||
|
||
performMutation(operation: Operation): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove from RFC before merging
Rendered