-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet another named blocks/yields RFC #193
Conversation
Regarding the drawback related to |
@joukevandermaas For sure. I don't think it's technical drawback really. I see it as more of a teaching/understanding drawback, since having two ways of doing the exact same thing is always undesirable. |
I like where this is going! I have some feedback/questions: 1. Block names?I don't quite understand why in their declaration the blocks have the string arguments ( 2.
|
@bendemboski I'll respond to your feedback by number:
|
I strongly support the need for this kind of functionality! It adds something that just using contextual components cannot give you, like the ability to specify where in the components template the blocks should be rendered to. Have been missing this very much... A bit unsure about the syntax of it though. But maybe one just has to get accustomed to it a bit... To underpin the need for it a little bit more:
|
Add changes to proposal suggested by @bendemboski and @simonihmig
Hide ancillary code blocks and large explanatory paragraphs by default to increase readability of RFC
Fix paragraph formatting within "Why ever?" section
Use details on "Why now" subsection
👍 for this. My team has been using a combination of contextual components and the ember-block-slots addon to construct some of our more complex components. If this RFC is implemented, we'll be able to refactor those components to provide a much more intuitive and fool-proof developer experience. Regarding the syntax, I think both |
Sorry to do this, but here's yet another yet another RFC that solves a similar problem: #199 |
Superseded by the now-merged Named Blocks RFC. |
Rendered