Skip to content

Commit

Permalink
Merge branch 'master' into missing-frontmatter
Browse files Browse the repository at this point in the history
  • Loading branch information
wagenet committed Aug 8, 2022
2 parents bb3b043 + 37cc993 commit bc6ebca
Show file tree
Hide file tree
Showing 18 changed files with 312 additions and 53 deletions.
26 changes: 5 additions & 21 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,35 +9,19 @@ jobs:
lint-frontmatter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Checkout tools repo
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: emberjs/rfcs-tooling
path: rfcs-tooling
ref: 'v1.0.0'

- uses: actions/setup-node@v2.1.2
- uses: actions/setup-node@v3

- run: yarn install
working-directory: rfcs-tooling

- name: Lint the frontmatter of all RFCs for informational purposes
run: node lint-rfc-frontmatter.js ../text/*.md || true # Don't want to fail on old RFCs just yet
working-directory: rfcs-tooling

- name: Get Changed Files
uses: lots0logs/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Filter Added Files to added RFCs
id: files
run: |
added_files=`jq -r '[.[] | select(startswith("text/"))] | join(" ")' ${HOME}/files_added.json`
echo "::set-output name=added::$added_files"
- name: Lint added RFCs frontmatter
if: ${{ steps.files.outputs.added }}
run: |
node rfcs-tooling/lint-rfc-frontmatter.js ${{ steps.files.outputs.added }}
run: node ./rfcs-tooling/lint-rfc-frontmatter.js text/*.md
36 changes: 22 additions & 14 deletions 0000-template.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,31 @@
---
Stage: Accepted
Start Date:
Release Date: Unreleased
Release Versions:
ember-source: vX.Y.Z
ember-data: vX.Y.Z
Relevant Team(s):
RFC PR:
stage: accepted
start-date:
release-date:
release-versions:
teams: # delete teams that aren't relevant
- cli
- data
- framework
- learning
- steering
- typescript
prs:
accepted: # update this to the PR that you propose your RFC in
project-link:
---

<!---
Directions for above:
Stage: Leave as is
Start Date: Fill in with today's date, YYYY-MM-DD
Release Date: Leave as is
Release Versions: Leave as is
Relevant Team(s): Fill this in with the [team(s)](README.md#relevant-teams) to which this RFC applies
RFC PR: Fill this in with the URL for the Proposal RFC PR
stage: Leave as is
start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z
release-date: Leave as is
release-versions: Leave as is
teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies
prs:
accepted: Fill this in with the URL for the Proposal RFC PR
project-link: Leave as is
-->

# <RFC title>
Expand Down
44 changes: 26 additions & 18 deletions deprecation-template.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,31 @@
---
Stage: Accepted
Start Date:
Release Date: Unreleased
Release Versions:
ember-source: vX.Y.Z
ember-data: vX.Y.Z
Relevant Team(s):
RFC PR:
stage: accepted
start-date:
release-date:
release-versions:
teams: # delete teams that aren't relevant
- cli
- data
- framework
- learning
- steering
- typescript
prs:
accepted: # update this to the PR that you propose your RFC in
project-link:
---

<!---
Directions for above:
Stage: Leave as is
Start Date: Fill in with today's date, YYYY-MM-DD
Release Date: Leave as is
Release Versions: Leave as is
Relevant Team(s): Fill this in with the [team(s)](README.md#relevant-teams) to which this RFC applies
RFC PR: Fill this in with the URL for the Proposal RFC PR
<!---
Directions for above:
stage: Leave as is
start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z
release-date: Leave as is
release-versions: Leave as is
teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies
prs:
accepted: Fill this in with the URL for the Proposal RFC PR
project-link: Leave as is
-->

# <RFC title>
Expand Down Expand Up @@ -46,7 +54,7 @@ re-organized or altered? Does it change how Ember is taught to new users
at any level?
Does it mean we need to put effort into highlighting the replacement
functionality more? What should we do about documentation, in the guides
related to this feature?
related to this feature?
How should this deprecation be introduced and explained to existing Ember
users?

Expand Down
4 changes: 4 additions & 0 deletions stages/accepted.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Accepted
order: 5
---
4 changes: 4 additions & 0 deletions stages/closed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Closed
order: 10
---
4 changes: 4 additions & 0 deletions stages/discontinued.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Discontinued
order: 11
---
4 changes: 4 additions & 0 deletions stages/exploring.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Exploring
order: 1
---
4 changes: 4 additions & 0 deletions stages/proposed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Proposed
order: 0
---
4 changes: 4 additions & 0 deletions stages/ready-for-release.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Ready For Release
order: 6
---
4 changes: 4 additions & 0 deletions stages/recommended.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Recommended
order: 8
---
4 changes: 4 additions & 0 deletions stages/released.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
name: Released
order: 7
---
3 changes: 3 additions & 0 deletions teams/cli.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
name: CLI
---
3 changes: 3 additions & 0 deletions teams/data.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
name: Data
---
3 changes: 3 additions & 0 deletions teams/framework.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
name: Framework
---
3 changes: 3 additions & 0 deletions teams/learning.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
name: Learning
---
3 changes: 3 additions & 0 deletions teams/steering.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
name: Steering
---
3 changes: 3 additions & 0 deletions teams/typescript.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
name: TypeScript
---
Loading

0 comments on commit bc6ebca

Please sign in to comment.