Skip to content

Commit

Permalink
cleanup interface section
Browse files Browse the repository at this point in the history
  • Loading branch information
runspired authored Mar 24, 2019
1 parent 328d192 commit 2e40c4f
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions text/0000-ember-data-identifiers.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,6 @@ foundation for mechanisms through which this can be later achieved.
## Detailed design

```typescript
const IS_IDENTIFIER = Symbol('is-identifier');

// provided for additional debuggability
const DEBUG_CLIENT_ORIGINATED = Symbol('record-originated-on-client');
const DEBUG_IDENTIFIER_BUCKET = Symbol('identifier-bucket');

export interface Identifier {
lid: string;
}
Expand Down Expand Up @@ -661,4 +655,4 @@ a multitude of benefits, including:
are also `ResourceIdentifierObjects`
* **ergonomics:** We can provide better `typescript` support for an object interface than a `string`
given that any `string` would fit the `lid` interface but only correctly shaped objects (which includes
the `Symbol` for `identifier`) would fit the correct object interface.
the `Symbol` for `identifier`) would fit the correct object interface.

0 comments on commit 2e40c4f

Please sign in to comment.