[FEATURE "ember-routing-transitioning-classes”] #9919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2014
|
👍 |
machty
force-pushed
the
transitioning-classes
branch
2 times, most recently
from
f8c610d to
ae6d319
Compare
|
Twitter-esque example: http://emberjs.jsbin.com/cageva/4/edit?html,css,js,output |
Disables eager URL updates during slow transitions in favor of new CSS classes added to `link-to`s (in addition to `active` class): - `transitioning-in`: link-to is not currently active, but will be when the current underway (slow) transition completes. - `transitioning-out`: link-to is currently active, but will no longer be active when the current underway (slow) transition completes.
machty
force-pushed
the
transitioning-classes
branch
from
ae6d319 to
9c56bc4
Compare
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Dec 19, 2014
[FEATURE "ember-routing-transitioning-classes”]
|
|
||
| var $index = Ember.$('#index-link'), $about = Ember.$('#about-link'), $other = Ember.$('#other-link'); | ||
|
|
||
| Ember.run($about, 'click'); |
There was a problem hiding this comment.
The click handler should already have a runloop inside it.
|
Anything I can do to help GO this feature? |
|
@ef4 ? did you post to wrong issue? |
|
No. I'm seeing code that is still wrapped in this feature flag. Should it not be? |
|
For context: I am cleaning up link-to to be a normal component, so I'm dealing with the transitioning classes. |
|
It is enabled by default. Flags can be removed. |
|
Cool, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables eager URL updates during slow transitions in favor of new CSS classes
added to
link-tos (in addition toactiveclass):transitioning-in: link-to is not currently active, but will bewhen the current underway (slow) transition completes.
transitioning-out: link-to is currently active, but will no longerbe active when the current underway (slow) transition completes.
This reverts the feature we added some months ago to eagerly update the URL even when a transition takes a while to complete; we realized that certain bugs (e.g. #5210 and #4908) didn't really otherwise have a clean solution since the original feature was at odds with the URL behavior people have come to expect from browsers.