Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TYPES] Directly assign a boolean value in deprecated-features #20732

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

wagenet
Copy link
Member

@wagenet wagenet commented Aug 21, 2024

Nightly TS rightly complains that !!'4.0.0-beta.1' is always true. Instead, we just use a boolean and add a comment telling when it was introduced.

@wagenet wagenet added Cleanup TypeScript Work on Ember’s types labels Aug 21, 2024
@kategengler kategengler merged commit 0377da6 into main Aug 21, 2024
11 of 22 checks passed
@kategengler kategengler deleted the fix-nightly-ts branch August 21, 2024 22:53
@NullVoxPopuli NullVoxPopuli mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants