Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated @ember/error #20384

Closed
wants to merge 1 commit into from
Closed

Remove deprecated @ember/error #20384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ function templateCompilerBundle(emberPackages, transpileTree) {
'@ember/canary-features/**',
'@ember/debug/**',
'@ember/deprecated-features/**',
'@ember/error/**',
'@ember/polyfills/**',
'ember/version.js',
'ember-babel.js',
Expand Down
53 changes: 0 additions & 53 deletions packages/@ember/error/index.ts
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions packages/@ember/error/tests/index_test.js
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/@ember/error/type-tests/index.test.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/@ember/object/lib/computed/computed_macros.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ export function oneWay(dependentKey: string) {
teddy.nickName; // 'Teddy'

set(teddy, 'nickName', 'TeddyBear'); // throws Exception
// throw new EmberError('Cannot Set: nickName on: <User:ember27288>' );`
// throw new Error('Cannot Set: nickName on: <User:ember27288>' );`

teddy.firstName; // 'Teddy'
```
Expand Down
7 changes: 0 additions & 7 deletions packages/@ember/routing/tests/system/router_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@ moduleFor(
owner = null;
}

['@test [GH#15237] EmberError is imported correctly'](assert) {
// If we get the right message it means Error is being imported correctly.
assert.throws(function () {
triggerEvent(null, false, []);
}, /because your app hasn't finished transitioning/);
}

['@test should not create a router.js instance upon init'](assert) {
let router = createRouter({ options: { disableSetup: true } });

Expand Down
4 changes: 0 additions & 4 deletions packages/ember/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ import VERSION from './version';
import * as views from '@ember/-internals/views';
import ContainerDebugAdapter from '@ember/debug/container-debug-adapter';
import DataAdapter from '@ember/debug/data-adapter';
import EmberError from '@ember/error';
import { run } from '@ember/runloop';
import { getOnerror, setOnerror } from '@ember/-internals/error-handling';
import EmberArray, { A, NativeArray, isArray, makeArray } from '@ember/array';
Expand Down Expand Up @@ -293,9 +292,6 @@ const PartialEmber = {
// ****@ember/enumerable/mutable****
MutableEnumerable,

// ****@ember/error****
Error: EmberError,

// ****@ember/instrumentation****
instrument: instrumentation.instrument,
subscribe: instrumentation.subscribe,
Expand Down
3 changes: 0 additions & 3 deletions packages/ember/tests/reexports_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,6 @@ let allExports = [
// @ember/enumerable
['Enumerable', '@ember/enumerable', 'default'],

// @ember/error
['Error', '@ember/error', 'default'],

// @ember/instrumentation
['instrument', '@ember/instrumentation', 'instrument'],
['subscribe', '@ember/instrumentation', 'subscribe'],
Expand Down
7 changes: 0 additions & 7 deletions type-tests/@ember/error-tests.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions types/preview/ember/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ declare module 'ember' {
import EmberArrayProxy from '@ember/array/proxy';
import type EmberEnumerable from '@ember/array/-private/enumerable';
import type EmberMutableEnumerable from '@ember/array/-private/mutable-enumerable';
// @ember/error
import type EmberError from '@ember/error';

type EmberArray<T> = EmberArrayNs.default<T>;
import type EmberActionHandler from '@ember/object/-private/action-handler';
Expand Down