[BUGFIX beta] revert TS compilerOptions.target to ES2017
#20283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one possible culprit behind #20281. We should, at minimum, only make this change in `target` intentionally, rather than incidentally.
chriskrycho
changed the title
compilerOptions.target to ES2017compilerOptions.target to ES2017
|
I can confirm this fixed the issue we were seeing! But: I don't have enough knowledge of what's going on in the build here to know why. |
dfreeman
approved these changes
Nov 29, 2022
|
Thanks for the confirmation—and yeah, we should definitely come back and iterate on this (as well as just getting off of broccoli-typescript-compiler). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20281. We should, at minimum, only make this change in
targetintentionally, rather than incidentally.