Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix release] Allow class-based helpers in strict-mode #19884

Conversation

NullVoxPopuli
Copy link
Contributor

#19877

Related: #19878

@NullVoxPopuli NullVoxPopuli force-pushed the fix-class-based-helpers-in-strict-mode branch from 44e0f68 to 0ffb67d Compare December 29, 2021 14:44
@NullVoxPopuli NullVoxPopuli force-pushed the fix-class-based-helpers-in-strict-mode branch from 0ffb67d to 07ac8a6 Compare December 29, 2021 14:46
Copy link
Member

@mixonic mixonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I would love a gut check from @chancancode @wycats or someone else close to the template/vm. This seems correct to me.

Copy link
Member

@chancancode chancancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@NullVoxPopuli
Copy link
Contributor Author

🥳 let's merge?

@kategengler
Copy link
Member

kategengler commented Jan 7, 2022

Is #19878 identical except for the targeted branch? (it looks so from a very quick look) If so, I think I'd prefer to merge that one and follow our normal release process.

@NullVoxPopuli
Copy link
Contributor Author

Yup. I thought targeting the release branch was the thing to do for bug fixes 🙃

@kategengler
Copy link
Member

Merged in #19878

Will backport.

@kategengler kategengler closed this Jan 7, 2022
@vstefanovic97
Copy link

@kategengler Hi! Can this be backported to a patch version for 3.28.* ? Thanks in advance!

@kategengler
Copy link
Member

@vstefanovic97 It is included in 4.2.0. #19878 was merged on Jan 7 with a tag of [Bugfix release], which would have it apply to 4.1.0.

I have to defer to others on whether this is important enough to backport to LTS cc @NullVoxPopuli @chancancode

@NullVoxPopuli
Copy link
Contributor Author

I submitted the fix for use with <template> / strict-mode templates / first-class-component-templates, and because the rfc was only recently merged, I'm 🤷 on if it should be back ported to previous LTS. Any project where I'm using <template> atm (via this addon), is using [email protected]+ so... 🤷

@chancancode
Copy link
Member

It’s probably a good idea if it’s easy to do (ie the changes apply cleanly). It would help with polyfills etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants