-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix release] Allow class-based helpers in strict-mode #19884
[Bugfix release] Allow class-based helpers in strict-mode #19884
Conversation
44e0f68
to
0ffb67d
Compare
0ffb67d
to
07ac8a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I would love a gut check from @chancancode @wycats or someone else close to the template/vm. This seems correct to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me
🥳 let's merge? |
Is #19878 identical except for the targeted branch? (it looks so from a very quick look) If so, I think I'd prefer to merge that one and follow our normal release process. |
Yup. I thought targeting the release branch was the thing to do for bug fixes 🙃 |
Merged in #19878 Will backport. |
@kategengler Hi! Can this be backported to a patch version for |
@vstefanovic97 It is included in 4.2.0. #19878 was merged on Jan 7 with a tag of [Bugfix release], which would have it apply to 4.1.0. I have to defer to others on whether this is important enough to backport to LTS cc @NullVoxPopuli @chancancode |
I submitted the fix for use with |
It’s probably a good idea if it’s easy to do (ie the changes apply cleanly). It would help with polyfills etc. |
#19877
Related: #19878