Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use positional and named as the argument names in ember g helper blueprint #19462

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Use positional and named as the argument names in ember g helper blueprint #19462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions blueprints/helper/files/__root__/__collection__/__name__.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { helper } from '@ember/component/helper';

export default helper(function <%= camelizedModuleName %>(params/*, hash*/) {
return params;
export default helper(function <%= camelizedModuleName %>(positional/*, named*/) {
return positional;
});
4 changes: 2 additions & 2 deletions blueprints/helper/mu-files/__root__/__collection__/__name__.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { helper as buildHelper } from '@ember/component/helper';

export function <%= camelizedModuleName %>(params/*, hash*/) {
return params;
export function <%= camelizedModuleName %>(positional/*, named*/) {
return positional;
}

export const helper = buildHelper(<%= camelizedModuleName %>);
4 changes: 2 additions & 2 deletions node-tests/fixtures/helper/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { helper } from '@ember/component/helper';

export default helper(function fooBarBaz(params/*, hash*/) {
return params;
export default helper(function fooBarBaz(positional/*, named*/) {
return positional;
});
4 changes: 2 additions & 2 deletions node-tests/fixtures/helper/mu-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { helper as buildHelper } from '@ember/component/helper';

export function fooBarBaz(params/*, hash*/) {
return params;
export function fooBarBaz(positional/*, named*/) {
return positional;
}

export const helper = buildHelper(fooBarBaz);