[CLEANUP] Removes the expandLocalLookup API
#19238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
changed the title
expandLocalLookup private APIexpandLocalLookup API
rwjblue
approved these changes
Oct 29, 2020
`expandLocalLookup` was a experimental API that was tied closely to Module Unification. The API was shipped, but was never fully released. It was primarily used for experimentation in general. Currently, 3 addons use it, all of which are experimental addons that try to establish MU like file structures. This PR removes the API to simplify resolution as a whole, so we can continue the work toward strict mode.
pzuraq
force-pushed
the
cleanup/remove-local-lookup
branch
from
87d1581 to
473d15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expandLocalLookupwas an experimental API that was tiedclosely to Module Unification. The API was shipped, but was never fully
released, as it was still marked as private. It was primarily used for
experimentation in general. Currently, 3 addons use it, all of which are
experimental addons that try to establish MU like file structures.
This PR removes the API to simplify resolution as a whole, so we can
continue the work toward strict mode.