Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 8 support. #18785

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Drop Node 8 support. #18785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,11 @@ jobs:
- yarn test

- name: Node.js Tests
node_js: "8"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default node_js is specified as 10 above, removing this line makes it use 10 instead of 8.

script:
- yarn ember build -prod
- yarn test:node

- name: Blueprint Tests
node_js: "8"
script:
- yarn test:blueprints

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
"tslint": "^5.20.1"
},
"engines": {
"node": "8.* || 10.* || >= 12.*"
"node": "10.* || >= 12.*"
},
"ember-addon": {
"after": "ember-cli-legacy-blueprints"
Expand Down