[BUGFIX beta] Ensure tag updates are buffered, remove error message #18694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2020 15:57
This update ensures that various forms of tag updates are buffered and removes the assertion that tags cannot be updated with a more recent version. Also adds tests for edge cases concerning combinations of computed properties, lazy dependencies, and observers that triggered this assertion.
pzuraq
force-pushed
the
bugfix/ensure-tag-updates-are-lazy
branch
from
b44fa38 to
1d3e83c
Compare
rwjblue
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures that various forms of tag updates are buffered and
removes the assertion that tags cannot be updated with a more recent
version. Also adds tests for edge cases concerning combinations of
computed properties, lazy dependencies, and observers that triggered
this assertion.