[BUGFIX] Ensure updateComponent is fired consistently
#18387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you have no args, or all static args, the custom component's (technically, the manager's) `updateComponent` hook will never fire. This is a VM bug that we need to fix, but in the mean time, this is a fine workaround that doesn't has much cost associated with it.
|
This is split from #18372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you have no args, or all static args, the custom component's (technically, the manager's)
updateComponenthook will never fire. This is a VM bug that we need to fix, but in the mean time, this is a fine workaround that doesn't has much cost associated with it.