Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing blueprints for MU dummy app. #17658

Merged
merged 4 commits into from
Mar 6, 2019

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Feb 24, 2019

Closes #17656

Fix the following commands for MU dummy apps:

  • ember g helper hola --dummy
  • ember g mixin hola --dummy
  • ember g service hola --dummy
  • ember g util hola --dummy

@ppcano ppcano mentioned this pull request Feb 24, 2019
4 tasks
@ppcano ppcano closed this Feb 26, 2019
@ppcano ppcano reopened this Feb 26, 2019
@ppcano
Copy link
Contributor Author

ppcano commented Feb 26, 2019

Re-run the test suite and CI passes now.

cc @rwjblue

@ppcano
Copy link
Contributor Author

ppcano commented Feb 26, 2019

There are also two pending blueprint PRs:

#17412
#17411

@rwjblue rwjblue merged commit 2d5375a into emberjs:master Mar 6, 2019
ppcano added a commit to ppcano/ember.js that referenced this pull request Mar 7, 2019
It fixes the test when generating a helper in a MU `dummy` app.

It continues the work of emberjs#17658 that requires this change when emberjs#17689 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants