Mark Application/Engine#buildInstance() as public #16883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Seems a test has timed out: https://travis-ci.org/emberjs/ember.js/jobs/415943656#L1248 |
|
pull request |
jamescdavis
force-pushed
the
mark_buildInstance_as_public
branch
from
b130716 to
7cacfd6
Compare
jamescdavis
force-pushed
the
mark_buildInstance_as_public
branch
from
7cacfd6 to
72da0db
Compare
rwjblue
approved these changes
Sep 3, 2018
|
Thank you! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is invoked in instance-initializer tests:
ember.js/blueprints/instance-initializer-test/qunit-rfc-232-files/tests/unit/instance-initializers/__name__-test.js
Line 15 in 0420806
ember.js/blueprints/instance-initializer-test/qunit-files/tests/unit/instance-initializers/__name__-test.js
Line 11 in 0420806
ember.js/blueprints/instance-initializer-test/mocha-files/tests/unit/instance-initializers/__name__-test.js
Line 14 in 0420806
Similar to #16842, this was also included in the suggestion by @rwjblue.