[FEAT] assert that actions cannot be sent from a destroyed/destroying object #16387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
force-pushed
the
assert-send-on-destroy
branch
from
eadf51b to
e00f26a
Compare
rwjblue
reviewed
Mar 22, 2018
|
|
||
| this.render('{{rip-alley}}'); | ||
|
|
||
| runDestroy(component); |
There was a problem hiding this comment.
I’d vaguely prefer a more natural way to destroy the component, e.g. render it in an if and toggle the condition
What do you think?
There was a problem hiding this comment.
@rwjblue didn't think of that, but I agree sticking closer to real world is best. Will update to that. Do we have a helper or do I need to wrap a set in a run?
stefanpenner
approved these changes
Mar 22, 2018
|
The failure is that browserstack timed out, all else passed. Can we reboot that? |
|
ya, I kicked that one.. |
rwjblue
approved these changes
Mar 22, 2018
rwjblue
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.