Fix didReceiveAttrs in ES Class #16185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
previously requested changes
Jan 28, 2018
| @@ -28,6 +28,7 @@ import { | |||
| assert, | |||
| deprecate, | |||
| } from 'ember-debug'; | |||
| import { ENV } from 'ember-environment'; | |||
There was a problem hiding this comment.
This is failing CI due to a linting error:
ERROR: /home/travis/build/emberjs/ember.js/packages/ember-glimmer/lib/component-managers/curly.ts[32, 1]: Import sources within a group must be alphabetized.
I believe this line should be moved down below import { DEBUG } from 'ember-env-flags';.
|
What’s the status? |
mmun
force-pushed
the
fix-did-receive-attrs-in-es-class
branch
from
60ffe33 to
abc2916
Compare
Adds a failing test for didReceiveAttrs in native classes. Class fields will likely be the prefered way to initialize default values on class instances, but because didReceiveAttrs is called in the base class constructor it is initially called before class fields have had an opportunity to be setup.
Running didReceiveAttrs inside of the base constructor means that it runs before subclass constructors (and ES fields in subclasses) are run. This commit moves didReceiveAttrs to the component manager (after creating the component), which changes the order it runs in, and causes it not to run when simply creating the component.
mmun
force-pushed
the
fix-did-receive-attrs-in-es-class
branch
from
abc2916 to
2cd6e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.