[Cleanup] Remove orphaned outlets #15916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorcan
force-pushed
the
lorcan/remove-orphaned-outlets
branch
from
c60d571 to
c12508d
Compare
Addresses emberjs#15876 (comment)
lorcan
force-pushed
the
lorcan/remove-orphaned-outlets
branch
from
c12508d to
767d469
Compare
lorcan
commented
Dec 2, 2017
| @@ -49,10 +49,6 @@ class SingletonRenderManager extends AbstractRenderManager { | |||
| this._pushToDebugStack(`controller:${name} (with the render helper)`, env); | |||
| } | |||
|
|
|||
| if (dynamicScope.rootOutletState) { | |||
| dynamicScope.outletState = dynamicScope.rootOutletState.getOrphan(name); | |||
There was a problem hiding this comment.
Is rootOutletState still needed at all?
lorcan
changed the title
lorcan
changed the title
|
@lorcan I believe for most of this we are going to need to create a new ENV variable that we can wrap this deprecated code in. Here is an example of what I am talking about: https://github.com/emberjs/ember.js/pull/15900/files. This will also require a PR into ember-2-legacy repo. If you need any help with either of these 2 things let me know. |
|
Great, thanks @thoov, I'll try that now. |
|
Closing in favour of #15925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15876 (comment)