Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom implementations of Map/MapWithDefault/OrderedSet #15898

Merged
merged 1 commit into from
Dec 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions packages/@ember/-internals/metal/tests/is_empty_test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { isEmpty } from '..';
import Map from '@ember/map';
import OrderedSet from '@ember/map/lib/ordered-set';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';

moduleFor(
Expand All @@ -25,31 +23,5 @@ moduleFor(
assert.equal(false, isEmpty({}), 'for an empty Object');
assert.equal(true, isEmpty(object), "for an Object that has zero 'length'");
}

['@test isEmpty Map'](assert) {
expectDeprecation(
() => {
let map = new Map();
assert.equal(true, isEmpty(map), 'Empty map is empty');
map.set('foo', 'bar');
assert.equal(false, isEmpty(map), 'Map is not empty');
},
'Use of @ember/Map is deprecated. Please use native `Map` instead',
{ id: 'ember-map-deprecation', until: '3.5.0' }
);
}

['@test isEmpty Ember.OrderedSet'](assert) {
expectDeprecation(
() => {
let orderedSet = new OrderedSet();
assert.equal(true, isEmpty(orderedSet), 'Empty ordered set is empty');
orderedSet.add('foo');
assert.equal(false, isEmpty(orderedSet), 'Ordered set is not empty');
},
'Use of @ember/OrderedSet is deprecated. Please use native `Map` instead',
{ id: 'ember-map-deprecation', until: '3.5.0' }
);
}
}
);
2 changes: 0 additions & 2 deletions packages/@ember/deprecated-features/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ export const EMBER_EXTEND_PROTOTYPES = !!'3.2.0-beta.5';
export const RUN_SYNC = !!'3.0.0-beta.4';
export const LOGGER = !!'3.2.0-beta.1';
export const ARRAY_AT_EACH = !!'3.1.0-beta.1';
export const MAP = !!'3.3.0-beta.1';
export const ORDERED_SET = !!'3.3.0-beta.1';
export const MERGE = !!'3.6.0-beta.1';
export const HANDLER_INFOS = !!'3.9.0';
export const ROUTER_EVENTS = !!'3.9.0';
Expand Down
218 changes: 0 additions & 218 deletions packages/@ember/map/index.js

This file was deleted.

Loading