Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove currentWhen property from link-to component #15884

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Remove currentWhen property from link-to component #15884

merged 1 commit into from
Nov 30, 2017

Conversation

locks
Copy link
Contributor

@locks locks commented Nov 29, 2017

No description provided.

@locks locks mentioned this pull request Nov 29, 2017
Closed
34 tasks
@rwjblue
Copy link
Member

rwjblue commented Nov 29, 2017

Since this is exposed as Ember.LinkComponent, I believe we can definitely move the implementation directly into the legacy addon (and use .reopen). Just need to make an issue on ember-2-legacy for this one, and cross link back here.

@locks locks mentioned this pull request Nov 29, 2017
Closed
@locks locks force-pushed the remove-link-to-current-when branch from d8b8d79 to f156c0d Compare November 29, 2017 22:32
@rwjblue rwjblue merged commit f1850bc into master Nov 30, 2017
@rwjblue rwjblue deleted the remove-link-to-current-when branch November 30, 2017 03:06
@thoov thoov mentioned this pull request Dec 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@locks @rwjblue