Run tests with Chrome headless. #15877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: Drop-in code replacement for Phantom with Chrome headless. The Google Chrome team came out with a slick JavaScript client library called [puppeteer](https://github.com/googlechrome/puppeteer) to control Chrome headless. This is a fairly (IMHO) straightforward port from running QUnit tests through Phantom to instead using Chrome headless. The functions are almost identical with the exceptions of how to actually boot/load up the browser and page, and also the logging code in-line. There are a few TODOs (things before this PR is merged) and Future Improvements (things likely out of scope for this PR) that I was able to come up with, though I'm sure I may have missed a few things: TODOs: - Extract out the `addLogging` function to a package similar to `qunit-phantomjs-runner` (`qunit-chrome-runner`?): right now copy and pasting the code from the Phantom runner works, but this isn't sustainable. Not sure if the Ember core team wants to maintain a small package like this, or who will own it. - Make sure testem is okay with removal of PhantomJS: there are a bunch of config files where Phantom is mentioned, those need to be looked at - Figure out when to remove Phantom completely from `bin` scripts: my initial thought was to run tests through both phantom and Chrome headless for a little while to make sure nothing was loudly failing, but I'll love feedback from reviewers about that Future Improvements: - Eventually remove all PhantomJS code from `bin` scripts - Remove `REDEFINE_SUPPORTED` / `handleBrokenPhantomDefineProperty` from [ember-metal](https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/properties.js) - Find a way to more responsibly handle browsers: I tried to setup some `browser.close()` calls to better manage the current situation, but things got messy quickly. I think this is outside of the scope of just getting this running in the first place. - Once Chrome headless hits stable release, add it as a Travis addon: currently the puppeteer npm package ships with a copy of the Chrome canary web browser, and it isn't necessary to install Chrome again - Finish migrating all Ember projects off of Phantom: ember-cli has already done the migration, not sure what other repos still need attention
Chrome is now the default browser used, no need to test it _again_...
Prior to this change, the only content emitted was `[Object object]`
(this is due to how puppeteer provides the argument to
`page.on('console', ...)`).
This was referenced Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and tweaked version of #15588 (thanks to @maclover7 for all of the actual hard work here).
Also, added a few commits on top of those changes for:
ChromeinTEST_SUITE=travis-browsersAddresses part of #15876.