make sure _isActive returns boolean in link-to
#15762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
commented
Oct 25, 2017
| let currentWhen = get(this, 'current-when'); | ||
|
|
||
| if (typeof currentWhen === 'boolean') { | ||
| return currentWhen ? get(this, 'activeClass') : false; |
There was a problem hiding this comment.
get(this, 'activeClass') is not boolean
There was a problem hiding this comment.
Hmm, this subtly changes the semantics. Previously you could specify activeClass: false and still never have _isActive return true...
There was a problem hiding this comment.
isn't that covered by tests ? that is still handled here https://github.com/bekzod/ember.js/blob/fcdd954c1cbf10df15c1afbdb4a03e99f54499bc/packages/ember-glimmer/lib/components/link-to.js#L590
bekzod
force-pushed
the
cleanup-linkto
branch
from
c26ca38 to
fcdd954
Compare
bekzod
force-pushed
the
cleanup-linkto
branch
from
fcdd954 to
5b215f7
Compare
locks
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.