Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC release] Document the result of hash is an empty object. #15500

Merged
merged 1 commit into from
Jul 14, 2017
Merged

[DOC release] Document the result of hash is an empty object. #15500

merged 1 commit into from
Jul 14, 2017

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Jul 13, 2017

Fixes #14489

@Serabe Serabe requested a review from locks July 13, 2017 17:30
locks
locks approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just waiting for serabe to prefix the commit with DOC release.

@Serabe Serabe changed the title Document the result of hash is an empty object. [DOC release] Document the result of hash is an empty object. Jul 14, 2017
@Serabe
Copy link
Member Author

Serabe commented Jul 14, 2017

Now sauce labs is passing.

@locks locks merged commit cb97ca5 into emberjs:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serabe @locks