Improve fastboot debugger/repl experience #15321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
commented
Jun 2, 2017
packages/container/lib/container.js
Outdated
| @@ -190,6 +190,13 @@ function wrapManagerInDeprecationProxy(manager) { | |||
| if (HAS_NATIVE_PROXY) { | |||
| let validator = { | |||
| get(obj, prop) { | |||
| // make work with node's formatValue | |||
| if (!(prop in obj)) { return ; } | |||
There was a problem hiding this comment.
this will obviously now fail if any of the following are actually defined on obj
Symbol(util.inspect.custom)Symbol(Symbol.toStringTag)
There was a problem hiding this comment.
One option, is to never trap:
- any symbol
- toString
stefanpenner
commented
Jun 2, 2017
| @@ -190,7 +190,10 @@ function wrapManagerInDeprecationProxy(manager) { | |||
| if (HAS_NATIVE_PROXY) { | |||
| let validator = { | |||
| get(obj, prop) { | |||
| if (prop !== 'class' && prop !== 'create') { | |||
| if (typeof prop === 'symbol') { return obj[prop]; } | |||
There was a problem hiding this comment.
I think never trapping symbols is perfectly good.
| @@ -190,7 +190,10 @@ function wrapManagerInDeprecationProxy(manager) { | |||
| if (HAS_NATIVE_PROXY) { | |||
| let validator = { | |||
| get(obj, prop) { | |||
| if (prop !== 'class' && prop !== 'create') { | |||
| if (typeof prop === 'symbol') { return obj[prop]; } | |||
| if (prop === 'inspect') { return undefined; /* for nodes formatter */ } | |||
There was a problem hiding this comment.
not happy about this one though...
|
I am not convinced we need to continue trapping |
That would greatly simplify this for-sure. As of what version do you feel comfortable dropping the |
We should land your current PR (basically blackholing all symbols and |
stefanpenner
force-pushed
the
fastboot-niceness
branch
from
56c8fb1 to
241d659
Compare
FactoryManager debug proxy and nodes formatValue don't play nicely. Basically, we throw when they legitimately try to inspect these objects. I'm not terribly happy with this solution, we can likely improve it. Maybe we should chat with the node folks to get there pulse on this... Original issue (this fixes) was from @locks -> stefanpenner/ember-console#8 Log: <details> <summary>TypeError: Cannot convert a Symbol value to a string</summary> ``` > app.instance TypeError: Cannot convert a Symbol value to a string at Object.get (/Users/ricardomendes/src/--ember/ember-cli-developer-tools/dist/assets/vendor/ember/ember.debug.js:9750:1) at formatValue (util.js:362:37) at formatProperty (util.js:822:15) at util.js:681:12 at Array.map (native) at formatObject (util.js:680:15) at formatValue (util.js:620:16) at formatProperty (util.js:822:15) at util.js:681:12 at Array.map (native) at formatObject (util.js:680:15) at formatValue (util.js:620:16) at formatProperty (util.js:822:15) at util.js:681:12 at Array.map (native) at formatObject (util.js:680:15) at formatValue (util.js:620:16) at Object.inspect (util.js:203:10) at REPLServer.self.writer (repl.js:459:19) at finish (repl.js:584:38) at REPLServer.defaultEval (repl.js:377:5) at bound (domain.js:280:14) at REPLServer.runBound (domain.js:293:12) at REPLServer.eval (/Users/ricardomendes/src/--ember/ember-cli-developer-tools/node_modules/await-outside/index.js:136:29) at REPLServer.onLine (repl.js:536:10) at emitOne (events.js:96:13) at REPLServer.emit (events.js:191:7) at REPLServer.Interface._onLine (readline.js:241:10) at REPLServer.Interface._line (readline.js:590:8) at REPLServer.Interface._ttyWrite (readline.js:869:14) at REPLServer.self._ttyWrite (repl.js:609:7) at ReadStream.onkeypress (readline.js:120:10) at emitTwo (events.js:106:13) at ReadStream.emit (events.js:194:7) at emitKeys (internal/readline.js:402:14) at emitKeys.next (<anonymous>) at ReadStream.onData (readline.js:980:36) at emitOne (events.js:96:13) at ReadStream.emit (events.js:191:7) at readableAddChunk (_stream_readable.js:178:18) at ReadStream.Readable.push (_stream_readable.js:136:10) at TTY.onread (net.js:561:20) ``` </details>
stefanpenner
force-pushed
the
fastboot-niceness
branch
from
241d659 to
74edc63
Compare
|
@rwjblue done |
rwjblue
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FactoryManager debug proxy and nodes formatValue don't play nicely. Basically, we throw when they legitimately try to inspect these objects.
I'm not terribly happy with this solution, we can likely improve it. Maybe we should chat with the node folks to get there pulse on this...
Original issue (this fixes) was from @locks -> stefanpenner/ember-console#8
Log:
TypeError: Cannot convert a Symbol value to a string