[BUGFIX LTS] Warn about invalid properties #15213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used |
|
Seems good to me. Choosing between |
There was a bug in the brace expansion implementation before 2.13 that
admitted expressions like `a.{b,c` and `a.b,c` in property expansion
without failing.
On February 2017, emberjs#13231 was merged improving the implementation of
`expandProperties` and fixing the previous issue.
Sadly, people upgrading from 2.12 are having problems with this. We have
two options here:
- Backporting emberjs#13231 fixes it and can be done, as of today, without any
problem just by cherry-picking its two commits. Sadly, this would
break people apps in a patch version, and this bug does not seem like
a critical bugfix.
- Adding a warning if a user is using invalid properties. I went with
this option since it looks like the less intrusive one while letting
the users know that their apps will break in the next update.
|
Updated messages to depend on the reason it stopped working. Properties like Thank you! |
Serabe
force-pushed
the
fix/add-warning-for-invalid-brace-expansions
branch
from
9b76588 to
d9217ed
Compare
rwjblue
approved these changes
May 12, 2017
|
Thank you @Serabe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the brace expansion implementation before 2.13 that
admitted expressions like
a.{b,canda.b,cin property expansionwithout failing.
On February 2017, #13231 was merged improving the implementation of
expandPropertiesand fixing the previous issue.Sadly, people upgrading from 2.12 are having problems with this. We have
two options here:
Backporting Correctly handle commas in CP property keys #13231 fixes it and can be done, as of today, without any
problem just by cherry-picking its two commits. Sadly, this would
break people apps in a patch version, and this bug does not seem like
a critical bugfix.
Adding a warning if a user is using invalid properties. I went with
this option since it looks like the less intrusive one while letting
the users know that their apps will break in the next update.