[DEPRECATION] (WIP) calling this._super when there is no method on parent class
#15082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
givanse
force-pushed
the
this_super
branch
3 times, most recently
from
4b74787 to
402b5aa
Compare
givanse
commented
Mar 27, 2017
packages/ember-metal/lib/mixin.js
Outdated
| * | ||
| */ | ||
| /* | ||
| deprecate( |
There was a problem hiding this comment.
copy-pasta from within this file as a sanity check, it errors with:
Uncaught Error: Ember.required is deprecated as its behavior is inconsistent and unreliable.
Uncaught TypeError: Cannot read property 'registerDeprecationHandler' of undefined
Uncaught TypeError: Cannot read property 'extend' of undefined
givanse
commented
Mar 27, 2017
packages/ember-metal/lib/mixin.js
Outdated
| @@ -129,6 +138,23 @@ function giveMethodSuper(obj, key, method, values, descs) { | |||
|
|
|||
| // Only wrap the new method if the original method was a function | |||
| if (superMethod === undefined || 'function' !== typeof superMethod) { | |||
| /* | |||
| deprecate( | |||
There was a problem hiding this comment.
Uncaught Error: Calling `_super` when there is no method on the parent class is deprecated.
🤔
There was a problem hiding this comment.
deprecate is meant to be executed at app runtime
givanse
changed the title
this._super when there is no method on parent class.this._super when there is no method on parent class
givanse
changed the title
this._super when there is no method on parent classthis._super when there is no method on parent class
givanse
changed the title
this._super when there is no method on parent classthis._super when there is no method on parent class
|
Apologies for letting this work linger all this time 😞 At this point I think rebasing this PR would be more work than starting anew so I'm closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14780
didDestroyElement, only available in interactive mode