[GLIMMER] Prevent auto-run assertion for objects not rendered. #14093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change any `Ember.set` done after **any** rendering has been done during tests will trigger the auto-run assertion. This change prevents the auto-run assertion when a given object has not been used in rendering process.
rwjblue
deleted the
prevent-auto-run-assertions-for-objects-not-in-templates
branch
This was referenced Aug 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #14091, but skip bumping revision altogether.
One of the invariants of the validators system is that whenever anything in the system has changed, the global revision must be incremented. However, we could define "the system" to be "the templating system", which restricts "anything in the system" to "anything objects observable from the templating system".
Since we always put a tag on everything the templating system cares about (i.e. we don't rely on
CURRENT_TAGas a safety net anymore), if an object does not already have a tag, it must mean that the view system doesn't care about it (yet).