Fixes #13750 update documentation to cast getJSON to compliant promise
#13752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: here's a twiddle showing that this approach works https://ember-twiddle.com/55ae031da0bfe8647440410ce9016d67 |
habdelra
changed the title
getJSON to compliant promisegetJSON to compliant promise
habdelra
changed the title
getJSON to compliant promisegetJSON to compliant promise
| @@ -60,6 +60,9 @@ function tap(proxy, promise) { | |||
|
|
|||
| When the $.getJSON completes, and the promise is fulfilled | |||
| with json, the life cycle attributes will update accordingly. | |||
| Note that $.getJSON doesn't return an ECMA spcified promise, | |||
There was a problem hiding this comment.
Small typo here: s/spcified/specified/
habdelra
force-pushed
the
promise-proxy-mixin-doc
branch
from
c2b18fc to
26879fa
Compare
|
@rwjblue needs your eyes |
|
@habdelra - 👓 |
|
Thank you! |
| @@ -38,7 +38,7 @@ function tap(proxy, promise) { | |||
| let ObjectPromiseProxy = Ember.ObjectProxy.extend(Ember.PromiseProxyMixin); | |||
|
|
|||
| let proxy = ObjectPromiseProxy.create({ | |||
| promise: $.getJSON('/some/remote/data.json') | |||
| promise: Ember.RSVP.cast($.getJSON('/some/remote/data.json')) | |||
There was a problem hiding this comment.
Ember.RSVP.cast is actually undocumented and in the source seems to be an alias to resolve Maybe resolve is a better choice since it is documented and used in the guides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from Wicked Good Ember contributing workshop in row #2 https://docs.google.com/spreadsheets/d/12lAjN5ro2UO4j30FbVtfCQgMgJaywSow8mA2OEbIIV0/edit#gid=0