Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable #1374

Merged
merged 1 commit into from
Sep 18, 2012
Merged

Remove unused variable #1374

merged 1 commit into from
Sep 18, 2012

Conversation

dlee
Copy link
Contributor

@dlee dlee commented Sep 14, 2012

Removing a declared but unused variable context.

@dlee
Copy link
Contributor Author

dlee commented Sep 14, 2012

Looks like the unused variable is a result of commit: 78d7450

We might want tomhuda to revisit this.

@dlee
Copy link
Contributor Author

dlee commented Sep 14, 2012

As another note, the code doesn't seem to reflect the comment:
https://github.com/emberjs/ember.js/blob/master/packages/ember-views/lib/views/view.js#L703-705

@wagenet
Copy link
Member

wagenet commented Sep 18, 2012

You're right, the comments are confusing. It seems that if you supply a context, that would take precedent over the controller. @wycats, @tomdale, can you chime in here?

@tomdale
Copy link
Member

tomdale commented Sep 18, 2012

Yep, it looks like #1 and #2 should be swapped.

tomdale added a commit that referenced this pull request Sep 18, 2012
@tomdale
Merge pull request #1374 from dlee/remove_unused_variable
117655b 
Remove unused variable
@tomdale tomdale merged commit 117655b into emberjs:master Sep 18, 2012
@dlee dlee mentioned this pull request Sep 18, 2012
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlee @wagenet @tomdale