[BUGFIX release] Remove wasted DK's for template and layout.
#12026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to observe and rerender properly when `template` or `layout` changed. As of 1.13 we do not rerender any longer, and the additional dependent keys cause extra unusable observers (which add up perf wise). It is unclear if the change to make `layout` not rerender is a regression, but we certainly shouldn't be paying for observation when we can't take advantage of it.
|
This is the first step in a suggestion by @krisselden to avoid creating CP's (and |
|
do we actually want these to be volatile? I would imagine them working as getter/setters with no caching would be accurate to our use-case. Or which use-case may i be missing. |
|
Discussed with @stefanpenner in chat. We are going to land this without |
rwjblue
added a commit
that referenced
this pull request
Aug 8, 2015
[BUGFIX release] Remove wasted DK's for `template` and `layout`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to observe and rerender properly when
templateorlayoutchanged. As of 1.13 we do not rerender any longer, and the additional dependent keys cause extra unusable observers (which add up perf wise).It is unclear if the change to make
layoutnot rerender is a regression, but we certainly shouldn't be paying for observation when we can't take advantage of it.