[BUGFIX release] Properly strip debug statements in prod builds. #11495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
rwjblue
force-pushed
the
strip-debug-statements
branch
from
aa91fd5 to
e956baf
Compare
In emberjs#11367 we swapped to using babel for module transpilation, which lead to the transpiled output being slightly different than previously with esperanto. The long term solution is to use a babel transform to strip, this will have the benefit of not having this particular issue any longer (this is actually the second time we have had this issue). https://github.com/ember-cli/babel-plugin-filter-imports has been created specifically for this purpose, and we have a roadmap to implementing soonish. --- This adds the new formats to the list of debug statements for defeatureify.
rwjblue
force-pushed
the
strip-debug-statements
branch
from
e956baf to
ee406a0
Compare
rwjblue
added a commit
that referenced
this pull request
Jun 18, 2015
[BUGFIX release] Properly strip debug statements in prod builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11367 we swapped to using babel for module transpilation, which lead to the transpiled output being slightly different than previously with esperanto.
The long term solution is to use a babel transform to strip, this will have the benefit of not having this particular issue any longer (this is actually the second time we have had this issue). https://github.com/ember-cli/babel-plugin-filter-imports has been created specifically for this purpose, and we have a roadmap to implementing soonish.
This adds the new formats to the list of debug statements for defeatureify.
Fixes #11494.