Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for rerendering after updating layout. #11315

Closed
wants to merge 1 commit into from

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 1, 2015

This test replicates #11301, #11186, and #12216.

@elwayman02
Copy link
Contributor

We have a component that renders a number of different layouts based on certain conditions and flows. In Ember 1.12.1, we were accomplishing this by updating the layoutName and then calling rerender. When I updated our app to 1.13, the old template was still rendered, even though the layoutName had been updated.

I've created JSbins illustrating the approximate issue we're seeing. The only difference is that in these examples, both the layout and layoutName attributes seem to be updating properly, whereas in our app, I'm not seeing layout update correctly when layoutName is changed. In either case, both the examples and our app fail to render properly in 1.13, so I'm hoping the solution will be the same for each.

Working 1.12 Example: http://emberjs.jsbin.com/payuqe/3/edit?html,js,output

Broken 1.13 Example: http://emberjs.jsbin.com/xufezo/2/edit?html,js,output

@JasonAllenCorns
Copy link

so...hey...any plans on merging this? @rwjblue tends to know what he's doing...

@mixonic
Copy link
Member

mixonic commented Mar 27, 2016

@ResentedHook this is a failing test, not an implementation of the fix.

@homu
Copy link
Contributor

homu commented Apr 11, 2016

☔ The latest upstream changes (presumably 604c291) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue rwjblue closed this Jul 5, 2016
@rwjblue rwjblue deleted the layout-rerendering branch July 5, 2016 03:28
@joankaradimov
Copy link

Can we expect this issue to ever be fixed?

@rwjblue
Copy link
Member Author

rwjblue commented Jul 12, 2016

No, I do not believe we will fix it. It was definitely a regression in 1.13, and I am terribly sorry about that. However, it was never supported in 2.x, and having layout for a component be static after init is pretty important for optimizations in Glimmer 2.

@joankaradimov
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants